search

heroku / libcnb.rs

A framework for writing Cloud Native Buildpacks in Rust
BSD 3-Clause "New" or "Revised" License
34 stars 6 forks source link

Add background dot printer #784

Closed schneems closed 2 months ago

schneems commented 6 months ago

The start_timer emits dots in the background while the buildpack does work. This is important for things like downloading a file while on spotty internet so that the user knows the buildpack isn't stuck.

edmorley commented 6 months ago

Thank you for the PR. Just to set expectations timing wise - I won't have a chance to look at this PR until next week, since there are several things in my queue (both review-wise, and the Python WEB_CONCURRENCY work) ahead of it.

schneems commented 6 months ago

Updated with a changelog entry.

I didn't add one as I wasn't expecting the buildpack output changes to be released in an unusable state. I wanted to avoid any conflicts to reduce the cost of maintaining a long-lived branch until it was being actively worked on.

We might want to pre-populate the ## [Unreleased] section with added/changed/removed along with bullet points for each of the sub libraries when we release. It won't prevent changelog conflicts, but would make them faster and more intuitive to resolve.

schneems commented 5 months ago

I'm going to rebase this and then I want to merge it in. If there's a refactor needed or some changes needed, then I'll own it. If it's not up to standards or quality, then we need to figure out additional ways to scale out standard and quality measures.

schneems commented 2 months ago

Think we can close in favor of using https://crates.io/crates/bullet_stream