search

heroku / logplex

[DEPRECATED] Heroku log router
Other
981 stars 96 forks source link

Cleanup supervisors #244

Closed ypaq closed 6 years ago

ypaq commented 6 years ago

Rationale

There were two unused simple 1-1 supervisors. These are now removed.

Changes

Remove logplex_read_queue_sup and logplex_reader_sup.

Details

logplex_reader_sup

There were no child processes supervised by logplex_reader_sup on any instance:

> sys:get_state(logplex_reader_sup).
{state,{local,logplex_reader_sup},
       simple_one_for_one,
       [{child,undefined,logplex_reader,
               {logplex_reader,start_link,[]},
               transient,2000,worker,
               [logplex_reader]}],
       undefined,1000,1,[],logplex_worker_sup,
       [logplex_reader]}

Furthermore, the module logplex_reader doesn't exist. Starting a child process on the this supervisor errors with undef.

logplex_read_queue_sup

There were no child processes supervised by logplex_read_queue_sup on any instance:

> sys:get_state(logplex_read_queue_sup).
{state,{local,logplex_read_queue_sup},
       simple_one_for_one,
       [{child,undefined,logplex_read_queue,
               {logplex_queue,start_link,[]},
               transient,2000,worker,
               [logplex_queue]}],
       undefined,1000,1,[],logplex_queue_sup,
       [logplex_read_queue]}

Furthermore, there are no calls to logplex_read_queue_sup:start_child


└▸ rg logplex_queue_sup
README.md
164:                          <tr><td></td><td></td><td> <a href="#logplex_read_queue_sup">logplex_read_queue_sup</a> (logplex_queue_sup)</td><td> logplex_queue</td><td></td></tr>
286:Starts a [logplex_queue_sup](./src/logplex_queue_sup.erl) process, registered as `logplex_read_queue_sup`, that supervises [logplex_queue](./src/logplex_queue.erl) processes.

src/logplex_queue_sup.erl
23:-module(logplex_queue_sup).

src/logplex_sup.erl
65:         {logplex_queue_sup, start_link,