search

heroku / nodejs-npm-buildpack

Heroku Cloud Native Buildpack for NPM on Node.js runtime
6 stars 7 forks source link

Broken No launch.toml process type #10

Closed brandonkal closed 5 years ago

brandonkal commented 5 years ago

Node builds do not function, and it appears to be as a result of no defined processes in launch.toml (which is not added here).

Given:

git clone https://github.com/heroku/node-js-getting-started.git
cd node-js-getting-started
pack build --builder heroku/buildpacks:18 js-heroku
docker run --rm -p 8080:8080 js-heroku

Result

Error: failed to launch: determine start command: process type web was not found The docker file built is present on dockerhub at brandonkal/js-heroku

As discussed on Slack, this works: docker run -p 8080:8080 js-heroku "npm start"

danielleadams commented 5 years ago

@brandonkal This is fixed with https://github.com/heroku/nodejs-npm-buildpack/pull/11, so I'm going to close this as it is resolved.