search

heroku / nodejs-npm-buildpack

Heroku Cloud Native Buildpack for NPM on Node.js runtime
6 stars 7 forks source link

Yarn support #13

Closed brandonkal closed 4 years ago

brandonkal commented 5 years ago

The nodejs-engine-buildpack installs yarn if a yarn.lock file is present. This buildpack should run yarn instead of npm if yarn is available. This will ensure the lock file is respected.

danielleadams commented 5 years ago

Hi @brandonkal, thanks for the issue. We're going to add yarn support in a different buildpack for a different builder path. I'll keep this issue open until it's posted so that it's communicated

brandonkal commented 5 years ago

Thank you. That makes sense given the name of this repo. I am curious how that would work as I am still exploring the CNB concept. Would that not require logic in this buildpack so they both don't run? It appears that the detect methods to apply both would be about the same.

hone commented 5 years ago

@brandonkal the yarn buildpack would detect for a yarn.lock vs this one. We can have just two buildpack groups one for yarn and one for npm.

danielleadams commented 4 years ago

@brandonkal Here's the yarn buildpack: https://github.com/heroku/nodejs-yarn-buildpack.

danielleadams commented 4 years ago

I'm going to close this issue since there's functionality supporting yarn now.