search

heroku / nodejs-npm-buildpack

Heroku Cloud Native Buildpack for NPM on Node.js runtime
6 stars 7 forks source link

new logging style #45

Closed lillianzhang331 closed 3 years ago

lillianzhang331 commented 3 years ago

Description

Replace our logging methods with the methods from the style guides: https://github.com/heroku/languages-team/pull/55/files

Checklist:

lillianzhang331 commented 3 years ago

@danielleadams This is failing the same timeout test as the engine buildpack was

Malax commented 3 years ago

@danielleadams This is failing the same timeout test as the engine buildpack was

@lillianzhang331, I can give you a rundown of the CNB testing framework I wrote that has, among other things, a solution for that issue. :) Just let me know.

danielleadams commented 3 years ago

Once this is merged https://github.com/heroku/nodejs-npm-buildpack/pull/46, it should pass. After that, I think we should look at the framework @Malax has created 😸