search

heroku / platform-api

Ruby HTTP client for the Heroku API
MIT License
214 stars 85 forks source link

Run tests on Circle CI #102

Closed schneems closed 4 years ago

schneems commented 4 years ago

It's worth mentioning why I deleted the Gemfile.lock

I do that in all my gems. When someone installs your gem for the first time they won't do it based off of the Gemfile.lock, but instead based off of whatever is in the gemspec. This allows CI to pick up the latest versions of dependencies available. it makes it more likely that CI will fail if there's a problem with upstream dependencies. Meaning it's more likely that we'll find and fix the problem It's pretty common. For example the excon gem does this https://github.com/excon/excon/blob/master/.gitignore#L13