search

heroku / platform-api

Ruby HTTP client for the Heroku API
MIT License
214 stars 85 forks source link

Add moneta as a dependency #59

Closed timminkov closed 7 years ago

timminkov commented 7 years ago

Looks like heroics stopped requiring moneta by default. Seeing as how we explicitly use moneta (client:48) we should assume moneta is a hard dependency as platform-api will not work without it.

This PR adds Moneta as a dependency in the Gemfile and requires it at runtime.

I think this is the PR that introduced the issue https://github.com/interagent/heroics/commit/79b38ee63d2eaaf3c31eb2999bbec279c671a0df

carlosantoniodasilva commented 7 years ago

Thanks @timminkov. I've hit the same issue after bumping heroics:

NameError: uninitialized constant PlatformAPI::Moneta
mathias commented 7 years ago

Yep, LGTM.

mathias commented 7 years ago

I'll cut a release for platform-api after we have a few more changes in heroics released, and this will be part of it.

bwebster commented 7 years ago

We just hit this as well. Looking forward to the new release.