search

heroku / platform-api

Ruby HTTP client for the Heroku API
MIT License
214 stars 85 forks source link

Use the new heroics name replacement features during client gen #60

Closed djcp closed 7 years ago

djcp commented 7 years ago

Includes using the new heroics config file feature to make client config generation more flexible.

djcp commented 7 years ago

CC @mathias

djcp commented 7 years ago

There's a couple method name changes probably necessitate a new major release, in addition to a bunch of new methods.

To see the method name changes, look at the diff against master for lib/platform-api/client.rb and search for list_by_add*. The old methods are the incorrect list_by_add_on and the new ones are the correct (and consistent) list_by_addon.

djcp commented 7 years ago

I say we cut this version as 1.0.0 and start following semver.

mathias commented 7 years ago

The diff looks much better in client.rb. And class names still look right for Addon*. Cool.

Let's polish up heroics and get it released?