Fully support test.salesforce.com, and handle windows home location.

heroku / salesforce-oauth-request

Util package to drive Salesforce Oauth Web flow for scripting and testing.

MIT License

34 stars 12 forks source link

Fully support test.salesforce.com, and handle windows home location. #2

Closed ianestrachan closed 10 years ago

ianestrachan commented 10 years ago

A fix for issue #1, implementing the suggestions from @lstrupinskaya. I ran into the same issues myself while using salesforce-bulk. So now:

If there is no HOME environment variable (such as in a Windows environment), join HOMEDRIVE and HOMEPATH together instead.
Check the sandbox flag for all outgoing requests to salesforce.com and properly point to login.salesforce or test.salesforce as appropriate.

aashay commented 10 years ago

Can we get this merged?

scottpersinger commented 10 years ago

Awesome, thank you. Sorry the delay. If anyone wants or needs commit rights just let me know. Use "scottp" at heroku.com.

aashay commented 10 years ago

Awesome, thank you Scott! Also, any chance we could get a pip version bump too?

scottpersinger commented 10 years ago

Ah, thanks for the reminder! Yes, pip package bumped.

On Mon, Aug 11, 2014 at 6:22 PM, Aashay Desai notifications@github.com wrote:

Awesome, thank you Scott! Also, any chance we could get a pip version bump too?

— Reply to this email directly or view it on GitHub https://github.com/heroku/salesforce-oauth-request/pull/2#issuecomment-51849095 .

lstrupinskaya commented 10 years ago

Hi Scott,

I did not add my changes to git. Besides module stopped working after salesforce upgrade on 7/21.

Our company decided not to use the module anymore.

On Mon, Aug 11, 2014 at 2:24 PM, Aashay Desai notifications@github.com wrote:

Can we get this merged?

— Reply to this email directly or view it on GitHub https://github.com/heroku/salesforce-oauth-request/pull/2#issuecomment-51843012 .