heroku / webapp-runner

Lightweight Application Launcher. Launch your webapp in the most popular open source web container available with a single command.
BSD 3-Clause "New" or "Revised" License
321 stars 112 forks source link

Reduce team review request noise from CODEOWNERS #423

Closed edmorley closed 10 months ago

edmorley commented 10 months ago

The CODEOWNERS file has been adjusted to request review from the primary repository maintainer for high-traffic files that are typically updated via automation, rather than requesting review from the whole team.

This:

In the scenarios where either the primary repository maintainer is away, or they are the person opening the PR (so can't request review from themselves), other team members will still be able to approve the PR with the changes I've made to the branch protection settings.

For supported syntax, see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

GUS-W-14941625.

Malax commented 10 months ago

In case anyone comes around this and wonders what

other team members will still be able to approve the PR with the changes I've made to the branch protection settings.

entails: The checkmark for "Require review from Code Owners" was disabled. But since "Require approvals" is still on, only people with write access can approve a PR for this repo. For us, this is almost the same set of people. The only additional personell that can now approve are org admins which have superpowers anyways.

I willing to give this a try and see how it works out over the coming months. Even if it immediately wouldn't work as expected, it's an easy thing to revert.