search

heroku / webapp-runner

Lightweight Application Launcher. Launch your webapp in the most popular open source web container available with a single command.
BSD 3-Clause "New" or "Revised" License
321 stars 112 forks source link

Correct the groupId #529

Closed earldouglas closed 1 month ago

earldouglas commented 1 month ago

The groupId in both pom.xml files is com.heroku, which matches the published artifacts:

https://search.maven.org/search?q=g:com.heroku%20a:webapp-runner

This updates the documentation to match.

Note that there are no artifacts published under com.github.heroku:

https://search.maven.org/search?q=g:com.github.heroku

edmorley commented 1 month ago

@earldouglas Hi 👋 Thank you for the PR! Our Java/JVM language owner is at a conference this week, so won't be able to look at this straight away, but I've flagged them for review for when they are back.

earldouglas commented 1 month ago

No rush; hope they enjoy the conference! Let me know if I can be of any help.

Malax commented 1 month ago

Hi @earldouglas!

thanks for your patience and this PR! Let's merge this!