'M' and 'O' commands in SerialCom are hardcoded to handle only 6 receiver channel

[GoogleCodeExporter]

I assume the configurator sends LASTCHANNEL values, so the loops have to run to 
LASTCHANNEL, not to 6, as it was in 2.4.2.

Original issue reported on code.google.com by al...@arcor.de on 25 Jul 2011 at 1:33

[GoogleCodeExporter]

Thanks for catching this, I thought I had removed that already.  It'll be gone 
in the next rev.  Is there any issue that you can see why we don't go back to 
v2.1 method of how you handle EEPROM?  I'm not sure why EEPROM map was 
stretched out the way it was.

Original comment by CaranchoEngineering@gmail.com on 25 Jul 2011 at 2:42

• Changed state: Accepted
• Added labels: Milestone-FlightSoftware_v2.4.4

[GoogleCodeExporter]

It is even worse. At the start of the transmitter calibration, you send just 6 
pairs of 1;0;, at the end you send 8 pairs of values. You have to send also 8 
pairs at the start.
The 'O' command caused a receiver buffer overflow on my STM32 port, the buffer 
was just 64 bytes long. Have to check how large the arduino buffer is...

Original comment by al...@arcor.de on 25 Jul 2011 at 2:50

[GoogleCodeExporter]

The arduino RX buffer is 128 bytes long, so there should be no problem with 
longer messages.

Original comment by al...@arcor.de on 25 Jul 2011 at 2:56

[GoogleCodeExporter]

>Is there any issue that you can see why we don't go back to v2.1 method of how 
you handle EEPROM?  I'm not sure why EEPROM map was stretched out the way it 
was.

A loop can still be used, but it looks a bit different now, as the offsets are 
handled with a structure definition now. I send you the loop code later today.

Original comment by al...@arcor.de on 25 Jul 2011 at 5:18

[GoogleCodeExporter]

OK, before I make another release I'll update the development branch in GitHub 
and send you a link.  I'd appreciate your Eagle eye to do a quick look through 
before I do another beta release.  THANK YOU!

Original comment by CaranchoEngineering@gmail.com on 25 Jul 2011 at 6:11

[GoogleCodeExporter]

Updated commands for M & O to use LASTCHANNEL.

Original comment by CaranchoEngineering@gmail.com on 25 Jul 2011 at 6:13

• Changed state: Fixed

[GoogleCodeExporter]

Here are the updated files which use loops to access the receiver slope, offset 
and smooth factor EEPROM data, which makes the binary ~800 bytes shorter.

Original comment by al...@arcor.de on 25 Jul 2011 at 11:16

Attachments:

• NVRFixes.zip

[GoogleCodeExporter]

Currently I can not test the last change, so make a transmitter calibration and 
check if it is ok.

Original comment by al...@arcor.de on 25 Jul 2011 at 11:26

[GoogleCodeExporter]

Implemented, needs test

Original comment by CaranchoEngineering@gmail.com on 26 Jul 2011 at 5:51

• Changed state: Started

[GoogleCodeExporter]

Original comment by CaranchoEngineering@gmail.com on 28 Jul 2011 at 7:30

• Changed state: Fixed