herolic / aeroquad

Automatically exported from code.google.com/p/aeroquad
0 stars 0 forks source link

Please remove Serial.print(x, bin) calls. #128

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In SerialCom.pde, please remove the output of byte values with the BIN mode. It 
is a bit of nonsense to print values of 0 and 1 in binary and they cause a 
problem with the maple lib. 

Replace
  SERIAL_PRINTLN(headingHoldConfig, BIN);
to
  SERIAL_PRINTLN((int)headingHoldConfig);

Replace
  SERIAL_PRINT(armed, BIN);
  comma();
to
  PrintValueComma((int)armed);

And while you are there, replace all
  armed = 0;
to 
  armed = OFF;

Original issue reported on code.google.com by al...@arcor.de on 25 Jul 2011 at 3:33

GoogleCodeExporter commented 9 years ago
Done, thanks!

Original comment by CaranchoEngineering@gmail.com on 25 Jul 2011 at 6:46