search

herolic / aeroquad

Automatically exported from code.google.com/p/aeroquad
0 stars 0 forks source link

Commands 1-5 are still not safe #133

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
armed = OFF; needs to be inside the if (readFloatSerial() == 123.45)
Commands 2-5 should also have and check the special value.

Original issue reported on code.google.com by al...@arcor.de on 26 Jul 2011 at 10:26

GoogleCodeExporter commented 9 years ago 
implemented (except for #4), needs test

Original comment by CaranchoEngineering@gmail.com on 27 Jul 2011 at 9:57

GoogleCodeExporter commented 9 years ago 
I made these changes
- fixed bugs in '5' and '`'
- added function to check for 123.45 to safe code space
- changed '4' to also check for 123.45, as you do not want a bad character on 
the serial to turn off armed in flight. Please adapt the configurator to handle 
this.
- fixed several wrong indentations
- changed 'J' to use PrintPID(ZDAMPENING)
- fixed bug in 'J' to send 10 numbers instead of previous 9
- added some loops to save code space
All this reduced the binary code length by 300 byte, with the other changes you 
made in SerialCom.pde we saved 600 byte compared to the 2.4.3 version :)

Original comment by al...@arcor.de on 27 Jul 2011 at 5:34

Attachments:

GoogleCodeExporter commented 9 years ago 
added to GitHub, needs test

Original comment by CaranchoEngineering@gmail.com on 27 Jul 2011 at 7:50