search

heromaster / glife

Girl Life (ЭТО) [English Community Version]
1 stars 1 forks source link

Village House of Culture - Dance dead end #12

Closed Thekingofsweden closed 9 years ago

Thekingofsweden commented 9 years ago

When dancing using the ticket in the house of culture in the village, if nothing interesting happens it will dead end, leaving the player with no way to continue.

Thekingofsweden commented 9 years ago

Looking at it more, I think there may be a few issues with the code for the sports section (gdksport), seeing that the 'Sports clubs are closed.' message is always up and it's set up as an else condition. I suspect mismatched end blocks or something. I may just try to rewrite the whole location, the code isn't really laid in an organized manner.

Thekingofsweden commented 9 years ago

Ug, looking at this file a bit deeper, there is an entire quest that looks like it may have only been partially implemented (fedorKozlovQW). The only place that ever sets the value is inside this location, but it's blocked by a UNSTARTER = 1 condition, and that variable is never set anywhere and is pretty obviously an attempt at an 'always false' condition. The classic 1 = 2 would have worked there. Anyway, do you know anything about that quest, as I am loathe to leave in a big block of code that can never occur.

heromaster commented 9 years ago

I guess this is one of the unfinished quests from the original creator. I never got it to work either (I believe this the one scene where you should get a surprise visit in the shower).

I hadn't encountered any problems with gdksport but I agree that doublechecking and cleaning some of the code is better.

About the dancing event I have to look into it myself, I remember there was some issue but I'm not entirely sure if I had it fixed or not.

Thekingofsweden commented 9 years ago

I've found some issues with the code, specifically an elseif that isn't matched up right, and it throws a bunch of it off. I'm currently cleaning it up and testing each section as I go.

I'm also strongly considering merging the DanceWhore1 - 8 files into gdksport as they only get called the once and they are simple progressions. Removing 8 locations without adding complexity is a win in my book.

As far as the quest, I'll probably leave it alone for now, finish up the cleanup of the location first and commit that, then perhaps take a stab at it since it crosses multiple locations.

heromaster commented 9 years ago

I agree

Thekingofsweden commented 9 years ago

I assume the same goes for the character Andrew that shows up in the Volleyball games on Friday. The location for him is nearly empty and looks like it was abandoned partway through.

Thekingofsweden commented 9 years ago

Push #13 had the fix for this, though I did leave the inactive quest in there alone for now.