heronarts / LX

Core library for 3D LED lighting engines
https://chromatik.co/
Other
41 stars 25 forks source link

Mavenize project. #18

Closed drichelson closed 5 years ago

drichelson commented 5 years ago

Addresses #17. Add maven support. This involved moving all source files into standard Maven locations. This was done via git mv command so history remains intact. Everything that was possible with ant before should doable with Maven, if not please let me know what is missing.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

mcslee commented 5 years ago

Thanks for that. Quick question - what's the recommended process for version updates / releases?

I assume master keeps working with version as: "0.1.3-SNAPSHOT"

When that's finished, shall I just make a commit to change it to "0.1.3" - then cut a release and a tag, and then immediately make another commit to change version to "0.1.4-SNAPSHOT"

Let me know if that'll be the best way to make it play nice with others...

drichelson commented 5 years ago

@mcslee The process you describe is exactly how I would do it. It is also exactly how the Maven release plugin works which may be a good option if you are releasing often or will have a CI system perform a release. Otherwise I'd stick with the manual approach.