search

heronarts / LX

Core library for 3D LED lighting engines
https://chromatik.co/
Other
41 stars 25 forks source link

Delete Channel undo selection state #23

Closed mcslee closed 5 years ago

mcslee commented 5 years ago

When a delete channel action is undone, selection should be removed from the currently selected items at some point in the process. [Or maybe more logically/specifically, the invisible action of auto-selection that happened after the delete should be undone prior to undoing the delete.] Steps to reproduce the problem:

  1. Add a few channels.
  2. Delete a channel(s) or group(s). Note that the item was selected before it was deleted.
  3. [Upon deletion, a neighboring channel is selected. This could also be a group or the Master channel.]
  4. Cmd+Z to undo the delete.
  5. [The item reappears and is selected.]
  6. [Now everything that was selected before and after the deletion is selected. This could be a combination normally not allowed to be selected, such as a Channel + Group, or a Channel + Master.]
mcslee commented 5 years ago

Should be fixed by: https://github.com/heronarts/LX/commit/0db89a714d213cf7b34af2eaf591978cb74ab2d5