search

heronarts / LX

Core library for 3D LED lighting engines
https://chromatik.co/
Other
41 stars 25 forks source link

example outputting to Tenere controller #5

Closed nargetdev closed 6 years ago

nargetdev commented 6 years ago

Still has index out of bounds exceptions with more than 180 points in model. No problem with less - that's why I changed the grid model to 10x17 . Also had to make fixtureToIndices( ... ) public, maybe there's a better way, but I feel like fixture should have an indices interface if there isn't one.

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

mcslee commented 6 years ago

Hey dude, slightly confused if this is just a duplicate of https://github.com/heronarts/LX/pull/4 or if there's new stuff in here.

Just FYI - I replied to all your questions via email. Also, if you get a chance, I would really like to know where the OutOfBounds exception is coming from. That def shouldn't be happening, so if you can post a stacktrace of the calls that are causing that, would be great to see.

Thanks man!

nargetdev commented 6 years ago

Hey Mark just getting to this, It’s been pretty wild times so I haven’t really looked since submitting. I had submitted #4 before realizing you’d fixed some of the issues so I was gonna fix the issues and PR again.

As for the index out of bounds, it seems to have gone away and I can’t reproduce it.

PR again soon

On Apr 19, 2018, at 11:54 AM, Mark Slee notifications@github.com wrote:

Hey dude, slightly confused if this is just a duplicate of #4 https://github.com/heronarts/LX/pull/4 or if there's new stuff in here.

Just FYI - I replied to all your questions via email. Also, if you get a chance, I would really like to know where the OutOfBounds exception is coming from. That def shouldn't be happening, so if you can post a stacktrace of the calls that are causing that, would be great to see.

Thanks man!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/heronarts/LX/pull/5#issuecomment-382843930, or mute the thread https://github.com/notifications/unsubscribe-auth/AGSpPL7c7jVgaY6a4Mjy-mj_OsSrospwks5tqN17gaJpZM4TbWcV.