search

heronsystems / adeptRL

Reinforcement learning framework to accelerate research
GNU General Public License v3.0
204 stars 29 forks source link

Bug and/or dead code in modular_network.py? #83

Open sflc6 opened 4 years ago

sflc6 commented 4 years ago

In particular, see here: https://github.com/heronsystems/adeptRL/blob/2d8b0d3be9d0530f0df55d7f4b919177f8767388/adept/network/modular_network.py#L216-L238

In the following if-statement:

if dim in head_submodules:
    continue

type(dim) == int; however, keys of head_submodules are guaranteed to be str due to the line head_submodules[str(dim)] = submod. This suggests that the above if-statement will never continue. Thoughts on this?

sflc6 commented 4 years ago

Perhaps we want dim = str(len(shape)) on line 220?