search

herosheets / woin-starships

Starship Creator for WOIN
http://herosheets.github.io/woin-starships/
1 stars 2 forks source link

Fuel Bay Alteration Does Nothing #68

Closed Morrus closed 8 years ago

Morrus commented 8 years ago

On top of the fuel bay alteration not being subtracted from the available CU's in the tool (it shows as 0 size on the builder table), it also doesn't affect operational range in the builder. I can add, then subtract, tons of fuel bay alterations, and the operational range for the ship stays the same.

Note that it says 0 CUs in the table, but that's because it can be a positive or negative value. I could replace that entry with two entires (one +1 CU, one -1 CU) if that would help. It still needs to feed into the operational range, though.

jsomara commented 8 years ago

The fuel bay alterations are not currently programmed to modify operational range. The current formula is:

(ship class^3) * (fuel efficiency of first engine)

Where does that belong in there?

Morrus commented 8 years ago

It's a simple 1:1 increase in range. If you select 150 fuel bay alterations, you just add +150 to the operational range (before applying the fuel efficiency multiplier).

On 7 Jun 2016, at 05:12, Jordan OMara notifications@github.com wrote:

The fuel bay alterations are not currently programmed to modify operational range. The current formula is:

(ship class^3) * (fuel efficiency of first engine)

Where does that belong in there?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

seiyria commented 8 years ago

For this I would like a simple ship dump to fully understand what's going on.

Morrus commented 8 years ago

Nothing is going on (yet). It's not so much a bug, as a feature from the rules which got missed. Every "unit" of fuel bay alteration that is purchased should increase the Operational Range by 1 parsec (before the engine's efficiency multiplier is applied).

Date: Tue, 7 Jun 2016 14:33:57 -0700 From: notifications@github.com To: woin-starships@noreply.github.com CC: morrus@hotmail.com; author@noreply.github.com Subject: Re: [herosheets/woin-starships] Fuel Bay Alteration Does Nothing (#68)

For this I would like a simple ship dump to fully understand what's going on.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Morrus commented 8 years ago

As far as I can tell, it doesn't. I just added 200+ fuel bay alterations to a ship, and the operational range did not change.

screen shot 2016-06-08 at 11 45 02
seiyria commented 8 years ago

Ok, so it's looking for "Fuel bay alteration" on my side, but I see you have it as "Fuel Bay Alteration" - it's case sensitive, so what do you want it to be?

Morrus commented 8 years ago

As shown in the data csv, please.

Date: Wed, 8 Jun 2016 06:25:00 -0700 From: notifications@github.com To: woin-starships@noreply.github.com CC: morrus@hotmail.com; state_change@noreply.github.com Subject: Re: [herosheets/woin-starships] Fuel Bay Alteration Does Nothing (#68)

Ok, so it's looking for "Fuel bay alteration" on my side, but I see you have it as "Fuel Bay Alteration" - it's case sensitive, so what do you want it to be?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.