search

herosheets / woin-starships

Starship Creator for WOIN
http://herosheets.github.io/woin-starships/
1 stars 2 forks source link

Save button does not work in Safari #73

Closed Morrus closed 8 years ago

Morrus commented 8 years ago

Seems OK in Firefox, but using Safari the save json button does nothing.

jsomara commented 8 years ago

@Morrus which version of safari did you use to test this?

Morrus commented 8 years ago

It's the Mac desktop version, 9.1.

On 7 Jun 2016, at 17:02, Jordan OMara notifications@github.com wrote:

@Morrus which version of safari did you use to test this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jsomara commented 8 years ago

That's the same version I'm running, so I'll check it out soon and let you know. Have you tried Chrome as well? If not, I'll add that to the list.

Morrus commented 8 years ago

I don't have Chrome, but I'll grab it and give it a try later.

seiyria commented 8 years ago

So here's the thing, Safari sucks. Some relevant discussion here: https://github.com/eligrey/FileSaver.js/issues/129 and here: https://github.com/eligrey/FileSaver.js/issues/12

When clicking Save, Safari users will see their ship data open in a new tab. They have to hit cmd+S, then change the format to "Page source", and then name the file, and hit save that way. It will still work normally in every other browser listed here: https://github.com/eligrey/FileSaver.js#supported-browsers