herotc / hero-lib

WoW Addon - Core Library used by HeroRotation and AethysTools, can also be used by others 3rd-Party Addons.
European Union Public License 1.2
44 stars 35 forks source link

Fury warrior - constant errors in combat #60

Closed WatersJohn closed 3 years ago

WatersJohn commented 3 years ago

BugSack logs the following:

1897x HeroRotation_Warrior\Fury-Fury.lua:229: attempt to index field 'VictoryRush' (a nil value) [string "@HeroRotation_Warrior\Fury-Fury.lua"]:229: in function?' [string "@HeroRotation\Main.lua"]:446: in function <HeroRotation\Main.lua:424>

Locals: ShouldReturn = nil (temporary) = nil (temporary) = nil (temporary) = 1 (temporary) = 35000 (temporary) = 0.002857 (temporary) = 35000 (temporary) = "player" (temporary) = "attempt to index field 'VictoryRush' (a nil value)" AoEON = defined @HeroRotation\Core.lua:355 Enemies8y =

{ 1 =
{ } } Player =
{ UseCache = true ChiDeficitPercentage = defined @HeroLib\Class\Unit\Player\Power.lua:596 GCDStartTime = defined @HeroLib\Class\Unit\Player\Stat.lua:70 Race = defined @HeroLib\Class\Unit\Player\Main.lua:46 Insanityrain = defined @HeroLib\Class\Unit\Player\Power.lua:648 FocusLossOnCastEnd = defined @HeroLib\Class\Unit\Player\Power.lua:226 PainMax = defined @HeroLib\Class\Unit\Player\Power.lua:725 IsInVehicle = defined @HeroLib\Class\Unit\Player\Main.lua:118 IsInParty = defined @HeroLib\Class\Unit\Player\Main.lua:33 EnergyDeficit = defined @HeroLib\Class\Unit\Player\Power.lua:279 Fury = defined @HeroLib\Class\Unit\Player\Power.lua:698 InstanceInfo = defined @HeroLib\Class\Unit\Player\Instance.lua:22 RageDeficit = defined @HeroLib\Class\Unit\Player\Power.lua:139 VersatilityDmgPct = defined @HeroLib\Class\Unit\Player\Stat.lua:119 FocusTimeToXPercentage = defined @HeroLib\Class\Unit\Player\Power.lua:202 MaelstromPercentage = defined @HeroLib\Class\Unit\Player\Power.lua:554 ArcaneCharges = defined @HeroLib\Class\Unit\Player\Power.lua:666 IsInDungeonArea = defined @HeroLib\Class\Unit\Player\Instance.lua:53 ActiveMitigationNeeded = defined @HeroLib\Class\Unit\Player\Tank.lua:57 UpdateActiveLegendaryEffects = defined @HeroLib\Class\Unit\Player\Equipment.lua:121 SoulShardsDeficit = defined @HeroLib\Class\Unit\Player\Power.lua:470 GetEnemiesInRange = defined @HeroLib\Class\Unit\Player\Enemies.lua:53 IsInWhitelistedVehicle = defined @HeroLib\Class\Unit\Player\Main.lua:154 PainDeficit = defined @HeroLib\Class\Unit\Player\Power.lua:740 AttackPower = defined @HeroLib\Class\Unit\Player\Stat.lua:78 FocusCastRegen = defined @HeroLib\Class\Unit\Player\Power.lua:208 PainDeficitPercentage = defined @HeroLib\Class\Unit\Player\Power.lua:745 PrevOffGCD = defined @HeroLib\Events\Prev_Spell.lua:236 MasteryPct = defined @HeroLib\Class\Unit\Player\Stat.lua:114 InsanityPercentage = defined @HeroLib\Class\Unit\Player\Power.lua:633 ManaDeficitPercentageP = defined @HeroLib\Class\Unit\Player\Power.lua:113 FuryDeficit = defined @HeroLib\Class\Unit\Player\Power.lua:708 PrevGCD = defined @HeroLib\Events\Prev_Spell.lua:202 AstralPowerMax = defined @HeroLib\Class\Unit\Player\Power.lua:482 IsMounted = defined @HeroLib\Class\Unit\Player\Main.lua:28 EnergyRegenPercentage = defined @HeroLib\Class\Unit\Player\Power.lua:289 RunicPowerDeficit = defined @HeroLib\Class\Unit\Player\Power.lua:389 FuryPercentage = defined @HeroLib\Class\Unit\Player\Power.lua:703 Insanity = defined @HeroLib\Class\Unit\Player\Power.lua:628 EnergyTimeToMaxPredicted = defined @HeroLib\Class\Unit\Player\Power.lua:336 Arcane`

Cilraaz commented 3 years ago
  1. This is a HeroRotation error, not a HeroLib error.
  2. This was fixed in this commit: https://github.com/herotc/hero-rotation/commit/4547e6bda3c12aede11a2e1989b96fcafde7df03