search

herotc / hero-lib

WoW Addon - Core Library used by HeroRotation and AethysTools, can also be used by others 3rd-Party Addons.
European Union Public License 1.2
44 stars 35 forks source link

[Bug]: Elemental Shaman AOE Detection does not function with Liquid Magma Totem #77

Closed mhunk closed 1 month ago

mhunk commented 2 months ago

What version of HeroLib are you using?

11.0.2.04

What is the issue?

Using SplashEnemies to determine AOE target count does not function for Liquid Magma Totem presumably from an incorrect spellID.

so, because totem shenanigans; the player casts liquid magma totem (192222) which itself casts Magma Eruption (395349) that then applies Flame shock (188389)

I'm not sure where in this chain, the detection needs to be and I'm assuming this is a HeroLib issue and not HeroRotation.

Cilraaz commented 1 month ago

This was previously fixed in commit https://github.com/herotc/hero-lib/commit/9ef821b8ec62fe072c0601bc01a5d9c77f9546be, but I forgot to update the ticket.