search

herotc / hero-rotation

WoW Addon - Attempt to provide the useful and precise information to execute the best possible DPS rotation in every situation.
European Union Public License 1.2
168 stars 125 forks source link

Add CD Functionality to Demo #1108

Closed joshjau closed 2 months ago

joshjau commented 2 months ago

Due to recent SimC updates, the 'Summon Demonic Tyrant' ability became de-synced from the cooldown toggle. This update reintroduces the option to properly sync Tyrant with the CD toggle, ensuring it only triggers when cooldowns are enabled.

Cilraaz commented 2 months ago

I had not put Tyrant on the CD toggle due to the majority of the APL being tied to its timing. Not using Tyrant when suggested can lead to unpredictable behavior, including the addon being stuck in the Tyrant() function, which is essentially just preparing for Tyrant's usage. I'll add the CDsON check in a separate commit (this PR misses one instance of Tyrant), but I can't ensure that it's not a large dps loss to delay Tyrant usage.