misc. bugfixes

[taherbert]

hi @Cilraaz!

This is a WIP PR for the upcoming VDH APL changes. These changes primarily address optimized trinket logic and a few minor fixes I found while using HR. I've implemented most of the logic changes, but I'm not sure how to implement the trinket changes.

Readable diff is here: https://github.com/Fel-Hammer/sim-toolkit/commit/1c33f42ba680f0e271299365796182c985eeca68

• vengeance/actions.simc

• vengeance/actions_aldrachi_reaver.simc

• vengeance/actions_felscarred.simc

• vengeance/full_character.simc (what simc will receive) is here: https://github.com/Fel-Hammer/sim-toolkit/blob/main/vengeance/full_character.simc

If you could give this a review and help implement the trinket logic (it's very similar to other APLs have), that would be a huge help. Thanks!

[taherbert]

After some testing, the logic needs a tweak somewhere -- this is giving incorrect recommendations for RG sequences.

EDIT: I'm trying some workarounds, but the overflow sequences aren't being sent in the correct order.=

[taherbert]

ok @Cilraaz, I think I have the issues sorted. The trinket logic needs a review, I tried to copy what others have done. Ideally, Bottled Flayedwing Toxin is excluded from trinket recommendations but I couldn't quite implement what is done elsewhere (e.g. Outlaw) without encountering errors. Maybe you or @Seny951 can help?