search

herotc / hero-rotation

WoW Addon - Attempt to provide the useful and precise information to execute the best possible DPS rotation in every situation.
European Union Public License 1.2
166 stars 126 forks source link

[Feral] Ferocious Bite w/no combo points #435

Closed solitha closed 5 years ago

solitha commented 5 years ago

Version: 8.0.1.12-27-g5dffee9-alpha Character: https://worldofwarcraft.com/en-us/character/us/silvermoon/solitha

HR is sometimes suggesting Ferocious Bite with no combo points. From what I've experienced, and my screenshot attempts, I think there are three factors here:

  1. Savage Roar was just used, using all combo points
  2. Tiger's Fury is still active
  3. Brutal Slash is recharging

This isn't a new problem, but it's been hard to pin down. WoWScrnShot_060119_153237

Cilraaz commented 5 years ago

This should be fixed in commit https://github.com/herotc/hero-rotation/commit/7a1fa5c5306ec9dd994a91903b9c658600495728

I changed Ferocious Bite to use IsReadyP instead of IsCastableP and, just to be safe, added a check to only suggest it at above 0 combo points.