herotc / hero-rotation

WoW Addon - Attempt to provide the useful and precise information to execute the best possible DPS rotation in every situation.
European Union Public License 1.2
166 stars 126 forks source link

[Demonology Warlock] A lot of errors due to missing argument #860

Closed c-ray-c closed 2 years ago

c-ray-c commented 2 years ago

if Cast(I.ResonantReservoir, nil, Settings.Commons.DisplayStyle.Trinkets, not Target:IsInRange()) then return "resonant_reservoir dmg 4"; end end -- use_item,name=architects_ingenuity_core if I.ArchitectsIngenuityCore:IsEquippedAndReady() then if Cast(I.ArchitectsIngenuityCore, nil, Settings.Commons.DisplayStyle.Trinkets, not Target:IsInRange()) then return "architects_ingenuity_core dmg 6"; end end -- use_item,name=cosmic_gladiators_resonator if I.CosmicGladiatorsResonator:IsEquippedAndReady() then if Cast(I.CosmicGladiatorsResonator, nil, Settings.Commons.DisplayStyle.Trinkets, not Target:IsInRange()) then return "cosmic_gladiators_resonator dmg 8"; end end

not Target:IsInRange() should have a number passed as argument, looks like:

image

Cilraaz commented 2 years ago

This is fixed in commit https://github.com/herotc/hero-rotation/commit/3d394a0643c34004617c795f29dcbae1ba8df486