search

herotc / legion.herodamage.com

Legion version of HeroDamage
https://legion.herodamage.com/
European Union Public License 1.2
5 stars 1 forks source link

[Scripts] Unify Trinket and Relic profiles #37

Closed Mystler closed 6 years ago

Mystler commented 6 years ago

Once the Relic script rework is pushed and Relic Sim requires only the base profile (like Trinkets), I think we should refactor the profiles for Trinkets and Relics to use the same template files, so we don't have to maintain them twice.

aethys256 commented 6 years ago

I feel like we should just scrap the profiles which use simc default and retrieves it from simc folder. If it's a different profiles (that isn't in default simc ones because different) then we fetch it from the ones on the repo.

We could let a way to add overrides for the simc default aswell, so we don't have to make a dedicated profile just for some simple override.

Mystler commented 6 years ago

Unified templates for non-combinator profiles in https://github.com/Ravenholdt-TC/SimcScripts/commit/bfc30167fc209ab2b37620f7734a2ff6944a8adb.