search

herpaderpaldent / seat-groups

SeAT group management
MIT License
9 stars 9 forks source link

non existing character causes bad exception #115

Open herpaderpaldent opened 5 years ago

herpaderpaldent commented 5 years ago

If user is present but character not yet loaded OR it has been deleted this will cause an exception upon index viewed.

This is due to bad seat-developers allowing to delete characters in character list.

https://github.com/herpaderpaldent/seat-groups/blob/311e3a8517372661983f3073f33306305de453b6/src/Models/SeatGroup.php#L172

Meganitrospeed commented 4 years ago

No way to fix it? @herpaderpaldent

herpaderpaldent commented 4 years ago

i guess a Null coalescing operator would help here: $user->character->corporation_id PR's are welcome

jim1471 commented 4 years ago

hi @herpaderpaldent I am also receiving this error on a fresh install