herrjulz / aviator

Merge YAML/JSON files in a in a convenient fashion based on a configuration file called aviator.yml
MIT License
60 stars 7 forks source link

add `--check-creds` flag to `fly` command #41

Closed dan-hill2802 closed 4 years ago

dan-hill2802 commented 4 years ago

Add additional option to Aviator to allow setting the fly set-pipeline commands --check-creds flag, which validates variables against Concourse's secrets engine.

Signed-off-by: Daniel Hill dan@mamu.co

dan-hill2802 commented 4 years ago

@herrjulz are you able to review this PR please?

herrjulz commented 4 years ago

@dan-hill2802 Sorry for my late response and thx for your PR. I just reviewed it and it looks good to me. The only thing I'm missing is a test case for the --check-creds flag in the flyexecutor but I can add it 👍 I will file a new release this week which will include your PR.