search

hertz-contrib / obs-opentelemetry

Opentelemetry for Hertz
Apache License 2.0
24 stars 26 forks source link

fix(metrics): not report status code 200 when http client returns error #50

Closed 2011aad closed 8 months ago

2011aad commented 8 months ago

What type of PR is this?

fix(metrics): do not report status code 200 when http client returns error

What this PR does / why we need it (English/Chinese):

en: Currently, http client report metrics status code as 200 when client returns an error. zh: 当前在http客户端返回错误时，metrics上报的status code是200。

Which issue(s) this PR fixes:

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

CoderPoet commented 8 months ago

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jianzhang.kk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

@2011aad CLA 需要处理下哈

rogerogers commented 8 months ago

ci 的 lint 需要修下