optimize: the registered address

hertz-contrib / registry

The service registration & discovery extensions for Hertz

Apache License 2.0

27 stars 39 forks source link

optimize: the registered address #90

Closed Skyenought closed 1 year ago

Skyenought commented 1 year ago

What type of PR is this?

optimize

What this PR does / why we need it (English/Chinese):

添加根据环境变量动态获取 ip port 的能力

Which issue(s) this PR fixes:

Skyenought commented 1 year ago

https://github.com/hertz-contrib/registry/pull/90/files#diff-b3ac597ed93b27ef58d5181e8dc8fc7f42b5d07fb2170fba0725bd6044bfafa1L126 register 的 serviceKey 里面没改
- _, err = e.etcdClient.Put(ctx, serviceKey(info.ServiceName, info.Addr.String()), string(val), clientv3.WithLease(leaseID))
+ _, err = e.etcdClient.Put(ctx, serviceKey(info.ServiceName, addr), string(val), clientv3.WithLease(leaseID))

我太马虎了

li-jin-gou commented 1 year ago

lgtm