search

hertzg / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

msvs generator may emit lf instead of crlf in headers for some python versions #10

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The msvs generator uses the built-in xml module. This module accepts an eol 
parameter which can 
be used to specify an alternate line ending. This is used for the msvs 
generator since visual studio 
and incredibuild expect crlf. Unfortunately some versions of python2.4 
(including unfortunately the 
one chromium has checked in) ignore this parameter when emitting the xml 
header. Fortunately, 
visual studio and incredibuild will accept either variant for the header. But 
it would be nice to be 
consistent. We should find an alternative that works on all python versions.

Original issue reported on code.google.com by bradnel...@google.com on 27 Apr 2009 at 7:34

GoogleCodeExporter commented 9 years ago 
Should be simple to fix, but not actually hurting anyone.  (The IDEs accept the 
inconsistent line ending on the first line, but it looks ugly...)

Original comment by sgk@chromium.org on 6 Aug 2009 at 5:33

GoogleCodeExporter commented 9 years ago

Original comment by sgk@chromium.org on 6 Aug 2009 at 5:33

GoogleCodeExporter commented 9 years ago

Original comment by sgk@chromium.org on 18 Aug 2009 at 8:10

GoogleCodeExporter commented 9 years ago 
In Node we're also hitting this. Doesn't hurt but people are complaining of 
ugly XMLs.

Original comment by coldredl...@gmail.com on 16 Aug 2011 at 5:14