search

hertzg / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

ninja generator doesn't build manifest files. #286

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

c:\chromiumtrunk\src>ninja -C out\Release chrome.exe
...
[257/257] LINK chrome.exe

c:\chromiumtrunk\src>ninja -C out\Release mini_installer
ninja: Entering directory `out\Release'
[24/93] LINK(DLL) chrome_frame_helper.dll
Generating code
Finished generating code
[28/93] LINK chrome_launcher.exe
Generating code
Finished generating code
[77/93] LINK chrome_frame_helper.exe
Generating code
Finished generating code
[82/93] RULE Create installer archive
FAILED: c:\Users\ukai\depot_tools\python_bin\python.exe gyp-win-tool action-wrap
per environment.x86 mini_installer_target_installer_archive_c729dd507a673af97a79
eeaaa5a51939.______chrome_installer_xxx2_out.rsp
['../tools/build/win/create_installer_archive.py', '--build_dir', '../../out/Rel
ease', '--staging_dir', '../../out/Release/obj/chrome/installer/mini_installer.g
en', '--input_file', 'mini_installer/chrome.release', '--resource_file_path', '.
./../out/Release/obj/chrome/installer/mini_installer.gen/packed_files.rc', '', '
--enable_touch_ui=1', '--component_build=1', '--distribution=_google_chrome']
Traceback (most recent call last):
  File "../tools/build/win/create_installer_archive.py", line 593, in <module>
    sys.exit(main(_ParseOptions()))
  File "../tools/build/win/create_installer_archive.py", line 509, in main
    DoComponentBuildTasks(staging_dir, options.build_dir, current_version)
  File "../tools/build/win/create_installer_archive.py", line 455, in DoComponen
tBuildTasks
    exe_manifest_dependencies, '</assembly>')
  File "../tools/build/win/create_installer_archive.py", line 320, in CopyAndAug
mentManifest
    manifest_file = open(os.path.join(build_dir, manifest_name), 'r')
IOError: [Errno 2] No such file or directory: '..\\..\\out\\Release\\chrome.exe.
manifest'
ninja: build stopped: subcommand failed.

chrome.exe.manifest is generated by VCManifestTool.AdditionalManifestFiles in 
chrome/chrome_exe.gypi, but no such rules for the file found in ninja manifests?

$ grep chrome.exe.manifest out/Release/obj/chrome/*.ninja
$

Original issue reported on code.google.com by ukai@chromium.org on 17 Jul 2012 at 4:04

GoogleCodeExporter commented 9 years ago 
Seems that fixed in r1437.

Original comment by yukawa@chromium.org on 2 Dec 2013 at 3:01