hertzg / node-gdate-julian

GDate (glib) style julian days to and from gregorian date converter
GNU Lesser General Public License v2.1
1 stars 0 forks source link

feat!: convert to esm #104

Closed hertzg closed 1 year ago

hertzg commented 1 year ago

Summary by OpenAI

Release Notes:

"Code changes abound, Bugs fixed, features found, ES modules now surround, Our codebase is newly crowned."

github-actions[bot] commented 1 year ago

:robot: OpenAI

High-level summary

The pull request contains changes to various files in the codebase, including modifications to workflow files, conversion of code to ES modules, and updates to type definitions. Some changes involve modifications to the logic and functionality of the code, while others are related to the conversion of the codebase to ECMAScript modules. Therefore, a thorough review is necessary to ensure that the changes do not introduce any bugs or security vulnerabilities.

Table of files and their summaries

File Summary
.github/workflows/cr.yaml Modifies the workflow file to trigger a review job on pull_request_review_comment event and uses a different action for code review.
.github/workflows/pr.yaml Updates the node versions used in the workflow to include the latest version 20.x and removes the older version 14.x.
.github/workflows/release.yaml Changes the Node.js versions used in the workflow and renames the workflow.
jest.config.js Converts the code to use ES modules and adds an empty transform object.
src/tests/date_conversion_spec.js Adds imports for two functions and modifies the test cases to use them. Also adds a helper function to create dates.
src/tests/date_leap_year_spec.js Imports a function from another module and uses it to test whether a list of years are leap years or not.
src/tests/g_date_conversion_spec.js Removes the import statements and test cases for g_date_to_julian_days and g_julian_days_to_date.
src/tests/g_date_leap_year_spec.js Removes the import statement and the test cases for g_date_is_leap_year function.
src/_make_julian_date.js Removes the entire contents of the file.
src/dateToJulianDays.js Imports the isLeapYear function from another module and uses it to calculate the number of days in a year. Also updates the code to use ES6 syntax.
src/g_date_is_leap_year.js Removes the export of a function and its implementation.
src/g_date_to_julian_days.js Removes the entire contents of the file.
src/g_julian_days_to_date.js Removes the entire contents of the file.
src/index.d.ts Removes the old type definitions and exports and replaces them with new ones. The names of the exported functions have also been changed to be more readable.
src/index.js Converts the code to ES modules and replaces require statements with export statements.

Chat with 🤖 OpenAI Bot (@openai)

Code suggestions


Files ignored due to filter (2) ### Ignored files * package-lock.json * package.json
Files not reviewed due to simple changes (8) ### Skipped review * .github/workflows/cr.yaml * src/__tests__/date_leap_year_spec.js * src/__tests__/g_date_conversion_spec.js * src/__tests__/g_date_leap_year_spec.js * src/g_date_is_leap_year.js * src/index.d.ts * src/isLeapYear.js * src/makeUTCDate.js
github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: