search

herumi / bls-eth-go-binary

68 stars 41 forks source link

Fix typo for freebsd support #35

Closed zi0r closed 3 years ago

zi0r commented 3 years ago

Fix FreeBSD support

herumi commented 3 years ago

Thank you for the patch, but when I tested it, the static binary generated on Linux also runs well on FreeBSD. So I think that it is okay to uses the Linux binary on FreeBSD. What do you think about it?

zi0r commented 3 years ago

The .a file included in the github repo does not work, at least when using prysm 1.3.3 under FreeBSD 12.2 amd64.

If I fix this line and built a FreeBSD version, it does work.

If you think about it, it doesnt make any sense that you'd need a separate ar for OSX and OpenBSD, but FreeBSD somehow worked fine with a Linux one?

herumi commented 3 years ago

I see. I'm not familiar with FreeBSD, and I thought that a Linux library always runs well on FreeBSD. Thank you.