herumi / bls-eth-go-binary

68 stars 41 forks source link

placing non-go files in subdirs prevents `go mod vendor` from working correctly #64

Open codyps opened 1 day ago

codyps commented 1 day ago

See https://github.com/golang/go/issues/26366 for some backstory here.

Essentially, go (and especially go mod vendor) doesn't like having subdirectories that aren't go packages that are depended on. Currently, this package tracks include/header files and binary library objects in subdirectories. As a result, any package that depends on bls-eth-go-binary (at any distance) will be broken when used with go mod vendor, because go mod vendor will not keep the header & library files because it doesn't consider them to be members of the module being depended on.

Potential fixes:

herumi commented 14 hours ago

If I place an empty.go file in each directory, can I keep the original file names? Since this project is sometimes used by non-Go projects, I'd like to minimize changes to file names and directory structure as much as possible.