search

herumi / bls-go-binary

22 stars 22 forks source link

Using semver for tags #16

Closed AdoAdoAdo closed 1 year ago

AdoAdoAdo commented 1 year ago

Currently referencing tag v1.29 does not work in go.mod as it does not follow semantic versioning MAJOR.MINOR.PATCH

Is it possible to create a tag that has also the PATCH version (e.g 1.29.0) ?

herumi commented 1 year ago

Okay, I've tagged it.

herumi commented 1 year ago

May the tag name not 1.29.0 butv1.29.0?

cnlangzi commented 1 year ago

May the tag name not 1.29.0 butv1.29.0?

yes, all module should be versioned with vX.Y.Z. but please create release instead of creating tag. release works properly with go get ...

AdoAdoAdo commented 1 year ago

May the tag name not 1.29.0 butv1.29.0?

Yes indeed, should be v1.29.0 :pray:

herumi commented 1 year ago

Okay, I used it.