herumi / bls-go-binary

22 stars 22 forks source link

the links seems be incorrect for andorid #22

Closed cnlangzi closed 1 year ago

cnlangzi commented 1 year ago

https://github.com/herumi/bls-go-binary/blob/d5cdac93b16788ec2075fe88e25b9b0c54c923b9/bls/link.go#L8

#cgo android,arm64 LDFLAGS:-L${SRCDIR}/lib/linux/arm64
#cgo android,arm LDFLAGS:-L${SRCDIR}/lib/android/armeabi-v7a
#cgo android,amd64 LDFLAGS:-L${SRCDIR}/lib/linux/amd64

should they be updated with

#cgo android,arm64 LDFLAGS:-L${SRCDIR}/lib/android/arm64-v8a
#cgo android,arm LDFLAGS:-L${SRCDIR}/lib/android/armeabi-v7a
#cgo android,amd64 LDFLAGS:-L${SRCDIR}/lib/android/x86_64
cnlangzi commented 1 year ago

it still doesn't work after links changed

# gobind/gobind
/opt/hostedtoolcache/go/1.19.4/x64/pkg/tool/linux_amd64/link: running /opt/hostedtoolcache/ndk/r21d/x64/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android21-clang failed: exit status 1
/opt/hostedtoolcache/ndk/r21d/x64/toolchains/llvm/prebuilt/linux-x86_64/bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin/ld: cannot find -lbls384_256
clang: error: linker command failed with exit code 1 (use -v to see invocation)

gomobile: go build -tags mobile -v -ldflags -s -w -extldflags=-Wl,-soname,libgojni.so -buildmode=c-shared -o=/tmp/gomobile-work-866617848/android/src/main/jniLibs/arm64-v8a/libgojni.so ./gobind failed: exit status 2