herumi / bls-go-binary

22 stars 22 forks source link

fix(ios): fixed build issue for iOS device and simulator #9

Closed cnlangzi closed 2 years ago

cnlangzi commented 2 years ago

Fixes

see example on https://github.com/0chain/gosdk/pull/499

cnlangzi commented 2 years ago

@herumi please don't forget to upload binaries of iOS and iOS simulator on bls/lib/ios and bls/lib/iossimulator. thanks.

herumi commented 2 years ago

Thanks for your patch. Could you rebase your commits into one commit?

cnlangzi commented 2 years ago

Thanks for your patch. Could you rebase your commits into one commit?

fixed.

herumi commented 2 years ago

I've merged it and released v1.27.

cnlangzi commented 2 years ago

@herumi could you build binaries(libbls384_256.a) for ios/iossimulator , and also upload them on bls/lib/ios and bls/lib/iossimulator? There are only 3 binaries for linux/windows/darwin on git repo now.

herumi commented 2 years ago

Those binaries are too big, I would not like to put them. Do you have any good ideas?

cnlangzi commented 2 years ago

Those binaries are too big, I would not like to put them. Do you have any good ideas?

add a github automated build action for it. Binaries will be built and included automatically on release branch And they are only included on release branches. I can implement it if you think it is ok.

herumi commented 2 years ago

Can you build all binaries for Linux, Windows, and Mac?

cnlangzi commented 2 years ago

Can you build all binaries for Linux, Windows, and Mac?

Yes. it is ok.

herumi commented 2 years ago

It sounds good. Could you show me the sample?

cnlangzi commented 2 years ago

It sounds good. Could you show me the sample?

OK. I will do a demo on my fork, and share you it once it is ready.