herumi / bls-wasm

BLS signature for Node.js by WebAssembly
47 stars 26 forks source link

add getLittleEndian in `SecretKey` class #19

Closed boddumanohar closed 10 months ago

boddumanohar commented 10 months ago

This PR adds a new method getLittleEndian in SecretKey class

testing procedure:

tested this by comparing this with the values returned by Go's implementation

boddumanohar commented 10 months ago

@herumi can you please take a look at this PR

herumi commented 10 months ago

Sorry for the delay. I'm busy right now, so please give me a little more time to check back later.

herumi commented 10 months ago

Your patch doesn't seem to work. You can use serialize() or serializeToHex() to get a byte code (or hexadecimal character string) as little-endian.

boddumanohar commented 10 months ago

thanks, using serialize() works. Closing the PR