search

herumi / bls

288 stars 132 forks source link

Build error #89

Closed b00f closed 1 year ago

b00f commented 1 year ago

The minimized_static target in Makefile has error. I tried to build like: MIN_WITH_XBYAK=1 make minimized_static; but I got another error. Any idea how to fix it?

You can check the log here: https://github.com/zarbchain/zarb-go/runs/7745122863?check_suite_focus=true#step:5:233

Actual command is like this: 

HERUMI= $(shell pwd)/.herumi
git clone --recursive https://github.com/herumi/bls.git $(HERUMI)/bls && cd $(HERUMI)/bls && make minimized_static;
herumi commented 1 year ago

Thank you for the report. I'll fix it. By the way, what environments do you want to use minimized_static?

herumi commented 1 year ago

If you need a static library including libmcl.a, then

make -f Makefile.onelib

generates it.

b00f commented 1 year ago

By the way, what environments do you want to use minimized_static?

Inside docker (Alpine-Linux)

herumi commented 1 year ago

I've fixed it at v1.28, but as I wrote at https://github.com/herumi/bls/issues/89#issuecomment-1210179994 , make -f Makefile.onelib is better.

b00f commented 1 year ago

@herumi thanks for the fix.