search

herumi / mcl-wasm

59 stars 18 forks source link

Move nyc from dependencies to devDependencies #17

Closed holgerd77 closed 3 years ago

holgerd77 commented 3 years ago

Hi @herumi, thanks for this great library, we are using it for the EIP-2537 BLS precompile implementation for our JavaScript EVM! 😄

We currently have the problem though that the nyc package currently being in the dependencies of the library is pulling in a hell lot of security vulnerabilities - some marked as high - when running npm audit on the library.

Would it be possible to merge and do a patch release on this relatively quickly? We are planning to do a new major version on the VM in two weeks and will feature-freeze at the end of next week (sorry, stumbled upon this a bit late in the process), and I'm afraid that we would otherwise have to disable the EIP-2537 support for now for security reasons.

That would be great and super helpful! 🙂

herumi commented 3 years ago

Thank you for the patch. I've changed the file-layout and removed the dependency. Could you check it?

rumkin commented 3 years ago

I've checked this exact issue and it's solved. I think this PR could be closed.