search

herumi / xbyak

A JIT assembler for x86/x64 architectures supporting MMX, SSE (1-4), AVX (1-2, 512), FPU, APX, and AVX10.2
BSD 3-Clause "New" or "Revised" License
2.05k stars 278 forks source link

Broken test suite on x86 (IA-32) #142

Closed Tachi107 closed 2 years ago

Tachi107 commented 2 years ago

As mentioned in https://github.com/herumi/xbyak/commit/6de93fb8843d471137637c644ce48947a8ad23cc#r68557045, commits 6de93fb8843d471137637c644ce48947a8ad23cc and 2bc8fcbd38a736727732489693d097f6c7fa56b8 introduced the usage of xm16 in the code, but that symbol is only defined when XBYAK64 is defined, i.e. on x86-64.

This causes test failures on x86, as you can see here.

I haven't submitted a PR as I don't know how you'd prefer to solve this :)

herumi commented 2 years ago

Thank you for pointing that out. I forgot that the test was in 64-bit mode only. I've fixed it.

Tachi107 commented 2 years ago

Thanks for the rapid fix!