search

herumi / xbyak

a JIT assembler for x86(IA-32)/x64(AMD64, x86-64) MMX/SSE/SSE2/SSE3/SSSE3/SSE4/FPU/AVX/AVX2/AVX-512 by C++ header
BSD 3-Clause "New" or "Revised" License
2.02k stars 276 forks source link

Reverting c7c1eac and 9f53572 #189

Closed Tachi107 closed 2 weeks ago

Tachi107 commented 3 weeks ago

Hi!

After the introduction of commits c7c1eac070851068d7adc3a67ad2efd196145687 and 9f535729159baf467c3bd8dc7ec017a40289a12c with pull request #186 by @keszybz, I've refrained myself from updating the package in Debian, since I wasn't sure that the changes were correct.

A few weeks ago I took some time to have a small discussion with Debian's cross-builds folks about my concerns, and they said that no, the pkg-config and CMake files should not be installed in the arch-independent directories, because xbyak cannot be used on all architectures.

You can find further reasoning, and the pros and cons of each approach, in the following messages (it wasn't a long discussion):

Therefore I'm opening this issue to coordinate with @keszybz to revert the changes without causing breakage to Fedora. In short, you should have different arch-specific packages, one for x86 which installs .pc files in /usr/lib, and one for x86_64 which installs files in /usr/lib64.

If you think this isn't correct, please let me know! Bye :)

herumi commented 3 weeks ago

Thank you for your feedback. @keszybz , what do you think about this? I am not familiar with packaging so I will follow the outcome of your discussion.

herumi commented 2 weeks ago

Hi @keszybz, If there are no particular comments by the end of this month, I will revert the noted commits.

Tachi107 commented 2 weeks ago

Hi @trixirt, pinging you too as you are the maintainer of the xbyak package on Fedora. What are your opinions on this?

On Wed Aug 28, 2024 at 2:43 AM CEST, MITSUNARI Shigeo wrote:

Hi @keszybz, If there are no particular comments by the end of this month, I will revert the noted commits. --
Reply to this email directly or view it on GitHub: https://github.com/herumi/xbyak/issues/189#issuecomment-2313867758

trixirt commented 2 weeks ago

In the last update to 7.07 there were other issues with meson build that lead me to go back to cmake and we only build for x86_64 so I do not know if reverting this change is necessary for fedora

Tachi107 commented 2 weeks ago

Interesting, what issue have you incountered? Looking at the Git history of Fedora packaging, you've skipped 7.06, which is where these arch-independent changes got introduced in the first place. Hence the pull request made by @keszybz never actually changed anything for Fedora.

The file move might actually be the issue you've encountered, so it makes sense to do the revert right now. @keszybz can always re-propose the patch in the future (making sure that it actually lands in Fedora, though!).

I'll submit a pull request shortly.

Tachi107 commented 2 weeks ago

Also, to avoid the issue keszybz has encountered, you should not mark xbyak as noarch, but should use rpm's equivalent of dpkg's "any".

herumi commented 2 weeks ago

Thanks.