57c4637 started changing variants into enums as an experiment. enums can be used as numbers or strings, but as they can change places easily in javascript, it introduced some silent type errors in the code. investigate where stronger typing can be enforced in these cases, otherwise revert to use variants for a more static type.
variant types should remain in code if their benefits can in fact be tapped, like pattern matching producing more concise code. otherwise enums can be used instead, mostly for their string values and ordering.
try a hybrid approach, with enums as tags for unions, if possible.
57c4637 started changing variants into enums as an experiment. enums can be used as numbers or strings, but as they can change places easily in javascript, it introduced some silent type errors in the code. investigate where stronger typing can be enforced in these cases, otherwise revert to use variants for a more static type. variant types should remain in code if their benefits can in fact be tapped, like pattern matching producing more concise code. otherwise enums can be used instead, mostly for their string values and ordering. try a hybrid approach, with enums as tags for unions, if possible.