herveus / Morsulus-tools

Morsulus's tool chain and related bits
http://www.morsulus.org
5 stars 3 forks source link

Complex Search form Name Pattern option is Case-sensitive #26

Open mathghamhain opened 3 years ago

mathghamhain commented 3 years ago

When you use the complex search form's name-pattern option, the values entered are case-sensitive.

This isn't obvious, and isn't convenient, as most people will not know about the (?i) inline modifier.

I think making this case-insensitive would be less surprising.

As an example of this problem, start by running a name-pattern search for mathghamhain and get over thirty results.

https://oanda.sca.org//oanda_np.cgi?p=mathghamhain&b=broad&c=case-insensitive&l=500&s=name+only&d=modern&g=disabled&a=disabled&raw=disabled

Then click the "convert to complex search" and get zero results:

https://oanda.sca.org//oanda_complex.cgi?a=disabled&d=modern&g=disabled&l=500&s=name%20only&w1=1&m1=name+pattern&p1=mathghamhain

herveus commented 3 years ago

Howdy!

I've implemented the fix in production. Both the regular and beta complex forms do a broad, case-insensitive name pattern search instead of the narrow, case-sensitive search they were doing.

yours, Herveus

On Mon, Aug 2, 2021 at 5:18 PM Mathghamhain Ua Ruadháin < @.***> wrote:

When you use the complex search form's name-pattern option, the values entered are case-sensitive.

This isn't obvious, and isn't convenient, as most people will not know about the (?i) inline modifier.

I think making this case-insensitive would be less surprising.

As an example of this problem, start by running a name-pattern search for mathghamhain and get over thirty results.

https://oanda.sca.org//oanda_np.cgi?p=mathghamhain&b=broad&c=case-insensitive&l=500&s=name+only&d=modern&g=disabled&a=disabled&raw=disabled

Then click the "convert to complex search" and get zero results:

https://oanda.sca.org//oanda_complex.cgi?a=disabled&d=modern&g=disabled&l=500&s=name%20only&w1=1&m1=name+pattern&p1=mathghamhain

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/herveus/Morsulus-tools/issues/26, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAECHSEFGP55LS7D4TF7UWLT24DTNANCNFSM5BNQVTMA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Michael Houghton | Herveus d'Ormonde @.*** | White Wolf and the Phoenix Lanham, MD, USA | Tablet and Inkle bands, and other stuff | http://whitewolfandphoenix.com