Investigate compiler warnings on Windows

herzbube / libsgfcplusplus

libsgfc++. A C++ library that uses SGFC to read and write SGF (Smart Game Format) data.

Apache License 2.0

12 stars 2 forks source link

Closed herzbube closed 3 years ago

herzbube commented 4 years ago

Investigate compiler warning C4251 on Windows platform
- Is emitted when SgfcConstants.h is included and something like std::string is encountered
Investigate compiler warning C4273 on Windows platform
- Is emitted when compiling SgfcPlusPlusFactory.cpp, on every static member function
- Is also emitted when compiling SgfcBoardSize

herzbube commented 3 years ago

Compiler warning C4251 has been disabled in commit aaa3beabc34fa2417d3bd5b628f66288845d0355. See the comment in src/CMakeLists.txt.

herzbube commented 3 years ago

Compiler warning C4273 no longer appears when building with Visual Studio 2019 on Windows 10.