Preserve SGFC source code analysis results

[herzbube]

All global variables are either marked static or extern. There are no variables outside functions that are not marked static or extern.

The following files do not contain any global variables (checked for static and anything that is outside functions)

• gameinfo.c
• strict.c
• all.h
• protos.h
• parse.c
• load.c

The following files contain static variables but no extern variables:

• parse2.c
• execute.c
• save.c

The following files contain both static and extern variables:

• util.c
• properties.c
• main.c

[herzbube]

extern globals declared/used in various files

• util.c
  • Various variables declared extern in protos.h int error_count = 0; int critical_count = 0; int warning_count = 0; int ignored_count = 0; char error_enabled[MAX_ERROR_NUM];
• properties.c
  • Variable declared extern in protos.h struct SGFToken sgf_token[] =
• main.c
  • Variables declared extern in protos.h struct SGFInfo *sgfc = NULL; char option_warnings = TRUE; [...] char *option_outfile = NULL;

[herzbube]

static globals declared/used in various files

• util.c
  • A global static not inside any function. This is safe because it's const. static const char *error_mesg[]
  • Various variables in PrintError static char *illegal, *last_pos; static int ill_count = 0; static U_LONG ill_type = E_NO_ERROR, last_type;
• parse2.c
  • In Init_TreeInfo() static int FF_diff = 0, GM_diff = 0;
  • Init_TreeInfo() is called by Check_SGFTree()
    • Repeatedly, as long as old == NULL, which it is during recursion level 0 of Check_SGFTree
  • Check_SGFTree() calls itself recursively with non-NULL as the second parameter - in that case Init_TreeInfo is NOT called
  • Check_SGFTree() is called by ParseSGF() with NULL as the second parameter (a BoardStatus struct) - in that case Init_TreeInfo is called
  • ParseSGF is called only once, from main()
  • So Init_TreeInfo() is called every time ParseSGF() is called, which is normally exactly once
  • The two static variables are set to 1 under certain circumstances
  • Conclusion
    • Init_TreeInfo() is called several times while parsing a single .sgf file
    • But for each .sgf file the static variables are reset
• execute.c
  • Two global statics not inside any function static U_LONG path_board[MAX_BOARDSIZE*MAX_BOARDSIZE]; static U_LONG path_num = 0;
• main.c
  • A global static not inside any function static struct SGFInfo sgf;
• save.c
  • Three global statics not inside any function static int save_linelen; static int save_chars_in_node; static int save_eol_in_node;
  • In WriteProperty() static int gi_written = FALSE;

[herzbube]

Call trees
----------

LoadSGF
+-- Everything not in ParseSGF and SaveSGF

ParseSGF
+-- Everything not in LoadSGF and SaveSGF

SaveSGF
+-- PrintError(FE_DEST_NAME_TOO_LONG | FE_DEST_FILE_OPEN | FE_DEST_FILE_WRITE) >>> Fatal Error
+-- WriteTree
    +-- SetRootProps
    |   +-- New_PropValue
    |       +-- Find_Property
    |       +-- Add_Property
    |       |   +-- SaveMalloc (#define)
    |       |   |   +-- PrintError(FE_OUT_OF_MEMORY) >>> Fatal Error
    |       |   +-- Enqueue
    |       |       +-- f_Enqueue
    |       |           +-- f_AddTail
    |       +-- Add_PropValue
    |           +-- SaveMalloc (#define)
    |           |   +-- PrintError(FE_OUT_OF_MEMORY) >>> Fatal Error
    |           +-- CopyValue
    |           |   +-- PrintError(W_CTRL_BYTE_DELETED) >>> Warning
    |           +-- AddTail
    +-- WriteNode
    |   +-- saveputc (#define)
    |   |   +-- WriteChar
    |   +-- CompressPointList
    |   |   +-- DecodePosChar
    |   |   +-- Del_PropValue
    |   |   |   +-- Delete (#define)
    |   |   |       +-- f_Delete
    |   |   +-- EncodePosChar
    |   |   +-- Add_PropValue >>> Siehe oben
    |   +-- WriteProperty
    |       +-- saveputc (#define)
    |       |   +-- WriteChar
    |       +-- WritePropValue
    |       |   +-- saveputc (#define)
    |       |   |   +-- WriteChar
    |       |   +-- WriteChar
    |       +-- CheckLineLen (#define)
    |           +-- saveputc (#define)
    |               +-- WriteChar
    +-- WriteTree <-- recursion
    +-- saveputc (#define)
        +-- WriteChar

[herzbube]

Most if not all of what was written in the previous comments is no longer valid since the changes that were made for SGFC v2.0. There's no point in preserving this information anymore in a structured format.