herzbube / libsgfcplusplus

libsgfc++. A C++ library that uses SGFC to read and write SGF (Smart Game Format) data.
Apache License 2.0
12 stars 2 forks source link

Find the root cause of build errors when targeting Windows SDK 10.0.17763.0 #38

Closed herzbube closed 11 months ago

herzbube commented 3 years ago

The build currently fails on Windows when it targets Windows SDK 10.0.17763.0.

Found this issue by accident on the windows-latest Github Actions runner where CMake currently selects the 10.0.17763.0 SDK by default. To workaround the problem the workflow config file build.yml currently has an explicit reference to the 10.0.18362.0 SDK, which is known to work.

cmake -DCMAKE_SYSTEM_VERSION="10.0.18362.0" ..

Having such an explicit SDK reference is bound to make problems in the future when the runner no longer contains the referenced SDK. The workaround should be removed, but before that can happen the root cause of the build errors must be found.

Cf. https://stackoverflow.com/q/65402366/1054378

herzbube commented 3 years ago

Some URLs gathered during research of build errors related to MSVC compiler warning C5105:

herzbube commented 11 months ago

The current windows-latest runner builds fine with the latest SDK. I consider this issue obsolete.